Skip to content

fix: remove the v4-migration legacy key from local storage#8353

Merged
sid-bruno merged 2 commits into
usebruno:mainfrom
prateek-bruno:fix/remove-v4-migration-key
Jul 2, 2026
Merged

fix: remove the v4-migration legacy key from local storage#8353
sid-bruno merged 2 commits into
usebruno:mainfrom
prateek-bruno:fix/remove-v4-migration-key

Conversation

@prateek-bruno

@prateek-bruno prateek-bruno commented Jun 24, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Description

Jira

v4-migration local storage key was introduced as a temporary migration notice for v3.5.x builds, warning them about affected APIs in their scripts.

In v4 that key becomes redundant, so this PR removes it.

Summary by CodeRabbit

  • Chores
    • Improved app startup cleanup by removing an outdated migration marker from browser storage.
    • This helps keep local settings tidy and reduces leftover data from older versions.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5b3af55c-d2ac-4ad1-9dc5-65d309991a72

📥 Commits

Reviewing files that changed from the base of the PR and between c7e33d6 and 6516961.

📒 Files selected for processing (1)
  • packages/bruno-app/src/providers/App/index.js

Walkthrough

AppProvider's initial mount effect now removes the v4-migration key from localStorage, clearing a legacy v3.5.0→v4 migration marker. No exported or public API signatures were changed.

Changes

Legacy Storage Cleanup

Layer / File(s) Summary
Mount effect cleanup
packages/bruno-app/src/providers/App/index.js		 Adds localStorage.removeItem('v4-migration') inside the existing initial mount useEffect.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A tiny hop, a key set free,
"v4-migration" — begone with thee! 🐇
One line added, mount effect neat,
Storage tidied, cleanup complete.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing the legacy v4-migration key from local storage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@prateek-bruno
fix: remove the v4-migration legacy key from local storage
6516961 
Co-authored-by: Prateek Sunal
<41370460+prateekmedia@users.noreply.github.com>
@prateek-bruno prateek-bruno force-pushed the fix/remove-v4-migration-key branch from c7e33d6 to 6516961 Compare July 2, 2026 07:04
@pull-request-size pull-request-size Bot added size/XS and removed size/S labels Jul 2, 2026
@sid-bruno sid-bruno merged commit 6f96dfd into usebruno:main Jul 2, 2026
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sid-bruno sid-bruno sid-bruno approved these changes
@helloanoop helloanoop Awaiting requested review from helloanoop helloanoop is a code owner
@bijin-bruno bijin-bruno Awaiting requested review from bijin-bruno bijin-bruno is a code owner
@lohit-bruno lohit-bruno Awaiting requested review from lohit-bruno lohit-bruno is a code owner
@naman-bruno naman-bruno Awaiting requested review from naman-bruno naman-bruno is a code owner
@vijayh-bruno vijayh-bruno Awaiting requested review from vijayh-bruno vijayh-bruno is a code owner
@utkarsh-bruno utkarsh-bruno Awaiting requested review from utkarsh-bruno utkarsh-bruno is a code owner

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prateek-bruno @sid-bruno